Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to React v18.2 #1571

Merged
merged 7 commits into from
Jun 15, 2022
Merged

Upgrade to React v18.2 #1571

merged 7 commits into from
Jun 15, 2022

Conversation

jplhomer
Copy link
Contributor

Description

Fixes #920
Fixes #1309
Fixes #1383

Additional context

React 18.2 is great!


Before submitting the PR, please make sure you do the following:

  • Read the Contributing Guidelines
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123)
  • Update docs in this repository according to your change
  • Run yarn changeset add if this PR cause a version bump based on Keep a Changelog and adheres to Semantic Versioning

@jplhomer jplhomer requested a review from a team June 14, 2022 21:20
@github-actions github-actions bot had a problem deploying to preview June 14, 2022 21:21 Failure
@github-actions github-actions bot had a problem deploying to preview June 14, 2022 21:25 Failure
Copy link
Contributor

@frehner frehner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the graphql.schema.json, probably need to revert that. :/

@jplhomer
Copy link
Contributor Author

jplhomer commented Jun 14, 2022

@frandiox do you know where we are with our Flight version? Does it include the useId() support? facebook/react#24172

@frandiox frandiox mentioned this pull request Jun 15, 2022
4 tasks
@frandiox
Copy link
Contributor

@jplhomer It does now: Shopify/hydrogen#1577 😄

@jplhomer jplhomer merged commit accdc78 into v1.x-2022-07 Jun 15, 2022
@jplhomer jplhomer deleted the jl-react-18-2 branch June 15, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants